Page MenuHomePhabricator

SpecialDisambiguationPages doesn't respect table prefixes
Closed, ResolvedPublic

Description

Screen Capture of db error

A database error occur, when you open the Special Page of DISAMBIG, here the error details:

Query:
SELECT page_props.pp_page AS value,page.page_namespace AS namespace,page.page_title AS title FROM wiki_page,wiki_page_props WHERE (page_id = pp_page) AND pp_propname = 'disambiguation' AND (page_namespace != 10) ORDER BY value LIMIT 51

function:
SpecialDisambiguationPages::reallyDoQuery

Error:
1054 Unknown column 'page_props.pp_page' in 'field list' (localhost)
(yes, without prefix)

If i'm right, a hotfix is:
Edit file: SpecialDisambiguationPages.php
find "'fields' => array("
delete table prefix "page_props" and "page"

Not tested on other wikis!

Wiki-Data:
URL droidwiki.de
MediaWiki 1.24wmf2
PHP 5.5.3-1ubuntu2.3 (apache2handler)
MySQL 5.5.37-0ubuntu0.13.10.1

Testwiki (not fixed):
http://wiki.go2tech.de/Spezial:Begriffsklärungsseiten
Thanks for fix!


Version: master
Severity: minor

Attached:

Details

Reference
bz65086

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:12 AM
bzimport set Reference to bz65086.
Florian created this task.May 9 2014, 5:58 PM
Reedy added a comment.May 9 2014, 6:00 PM

1.24wmf2 is out of date. I'd suggest upgrading to 1.24wmf4...

Reedy added a comment.May 9 2014, 6:03 PM

Oh, ignore me. It needs the prefixing fixing

Change 132474 had a related patch set uploaded by Reedy:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132474

Applied patch -> working

Info only:
You are right, sorry, i missed two updates, wasn't good to open bug before ensure the newest git version (when not use the official release branch). I have updated and the error was the same, like you know, but after patch it work :)

Patch hasn't been merged yet, but thanks for verifying it's working!

It should also be backported to REL1_23 (and older?) branch once merged.

Change 132474 merged by jenkins-bot:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132474

Change 132481 had a related patch set uploaded by Reedy:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132481

Change 132482 had a related patch set uploaded by Reedy:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132482

Change 132481 merged by jenkins-bot:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132481

Change 132482 merged by jenkins-bot:
Fix table prefixing in SpecialDisambiguationPages

https://gerrit.wikimedia.org/r/132482

MaxSem added a comment.May 9 2014, 6:52 PM

Stupid bot.