[EPIC] Hovercards: Test Coverage
Closed, ResolvedPublic
Actions

Description

Test coverage is very low. What needs to be set up and tested?

See subtasks for work.

Details

Reference: bz65103

	Subject	Repo	Branch	Lines +/-
	tests: Add render.article.createImgThumbnail	mediawiki/extensions/Popups	master	+17 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Declined	Jdlrobson	T111329 [GOAL] Page previews on mobileweb
Resolved	phuedx	T133947 [EPIC] Reduce bloat of Page Previews RL module(s)
Resolved	Jdlrobson	T144522 [EPIC] Hovercards technical debt and quality enhancements
Resolved	Jdlrobson	T67103 [EPIC] Hovercards: Test Coverage
Resolved	None	T133017 Spike: What's tested and what needs testing in Hovercards
Resolved	Jdlrobson	T133018 Set up browser tests running on CI (jenkins) for Hovercards
Resolved	Jdlrobson	T133019 Create browser tests for hovering link and showing hovercard
Resolved	Jdlrobson	T133020 Unit test ext.popups.core.js
Resolved	None	T133022 Unit test src/renderer.js
Duplicate	None	T133162 Unit test ext.popups.renderer.article.js (part 2 HARD)
Invalid	None	T133023 Unit test ext.popups.disablenavpop.js
Resolved	• Jhernandez	T133024 Unit test ext.popups.logger.js
Invalid	None	T133055 Split ext.popups.settings.js in units
Resolved	phuedx	T133025 Unit test ext.popups.settings.js
Resolved	phuedx	T133054 Create browser test for add footer link in ext.popups.settings.js
Resolved	Jdlrobson	T133163 BetaFeatures test failure

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:14 AM

• bzimport added a project: Page-Previews.

• bzimport set Reference to bz65103.

• bzimport added a subscriber: Unknown Object (MLST).

• Prtksxna created this task.May 9 2014, 8:20 PM

• Jaredzimmerman-WMF triaged this task as Medium priority.Dec 3 2014, 12:30 AM

• Jaredzimmerman-WMF updated the task description. (Show Details)

• Jaredzimmerman-WMF set Security to None.

• Prtksxna moved this task from Backlog to In Development on the Page-Previews board.Dec 3 2014, 5:33 AM

Krinkle added a project: Technical-Debt.Dec 10 2014, 1:50 PM

Krinkle subscribed.

Change 179106 had a related patch set uploaded (by Prtksxna):
tests: Add render.article.createImgThumbnail

https://gerrit.wikimedia.org/r/179106

Patch-For-Review

yuvipanda unsubscribed.Jan 12 2015, 11:54 AM

Change 179106 abandoned by Prtksxna:
tests: Add render.article.createImgThumbnail

Reason:
I think I am doing something utterly useless here. The code in the test is the same as the function.

Krinkle, does this make sense?

https://gerrit.wikimedia.org/r/179106

Jdlrobson updated the task description. (Show Details)Sep 23 2015, 9:18 PM

Jdlrobson removed a project: Patch-For-Review.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2015, 9:18 PM

Jdlrobson lowered the priority of this task from Medium to Low.Dec 17 2015, 8:28 PM

Jdlrobson subscribed.

Jdlrobson moved this task from In Development to Needs Analysis on the Page-Previews board.Mar 22 2016, 9:53 PM

Krinkle unsubscribed.Mar 22 2016, 10:46 PM

dr0ptp4kt added a project: Reading-Web-Sprint-70-Lady-and-the-Trumps.Apr 4 2016, 3:20 PM

dr0ptp4kt renamed this task from Hovercards: Write Tests to Hovercards: Test Coverage.Apr 4 2016, 4:41 PM

dr0ptp4kt updated the task description. (Show Details)

dr0ptp4kt set the point value for this task to 3.Apr 4 2016, 4:46 PM

dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.

OK, here is my analysis so far:

1. ext.popups.core.js

Not tested:

mw.popups.removeTooltips
mw.popups.setupTriggers
mw.popups.selectPopupElements

Tested:

mw.popups.getTitle

2. ext.popups.renderer.article.js

Not tested:

article.createPopup
article.removeParensFromText
article.createSVGTag
article.createThumbnail
article.createSvgImageThumbnail
article.createImgThumbnail
article.getOffset
article.getClasses
article.processPopup

Tested:

article.getProcessedElements
mw.popups.render.getClosestYPosition

3. These files are not tested: ext.popups.disablenavpop.js, ext.popups.logger.js, ext.popups.settings.js.

dr0ptp4kt edited projects, added Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters; removed Reading-Web-Sprint-70-Lady-and-the-Trumps.Apr 11 2016, 6:08 PM

dr0ptp4kt moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters board.Apr 11 2016, 6:21 PM

I think this task is definitely more than a 3 pointer (probably an 8) because the extension is covered sparsely.

• bmansurov claimed this task.Apr 13 2016, 8:45 PM

• bmansurov added a project: Reading-Web-Sprint-70-Lady-and-the-Trumps.

• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.

Change 283348 had a related patch set uploaded (by Bmansurov):
WIP: Add QUnit tests to cover ext.popups.core.js

https://gerrit.wikimedia.org/r/283348

gerritbot added a project: Patch-For-Review.Apr 13 2016, 10:49 PM

We should take care when doing this that we write the write tests. Browser tests may be better in some places and there may not be value in testing certain units.

… as this was brought into the sprint after it began.

Change 283566 had a related patch set uploaded (by Bmansurov):
Add basic browser tests

https://gerrit.wikimedia.org/r/283566

Change 283568 had a related patch set uploaded (by Bmansurov):
Create Popups jenkins job

https://gerrit.wikimedia.org/r/283568

• bmansurov updated the task description. (Show Details)Apr 14 2016, 10:26 PM

Change 283762 had a related patch set uploaded (by Bmansurov):
Add QUnit tests for ext.popups.logger

https://gerrit.wikimedia.org/r/283762

dr0ptp4kt removed a project: Reading-Web-Sprint-71-Matisse-Monet-Kandinsky-and-the-Departing-Painters.Apr 16 2016, 8:32 PM

• Jhernandez moved this task from Doing to Needs Analysis on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 18 2016, 4:46 PM

I'm taking this back to transform it to an Epic and get it better fleshed out and split to pieces.

The spike already done and other work we need to do taking into account the spike's results.

@bmansurov I'll split tasks for the patches you already have, and change the patches to link to the correct bugs. We can talk tomorrow if there is something wrong.

• Jhernandez created subtask T133017: Spike: What's tested and what needs testing in Hovercards.Apr 19 2016, 9:11 AM

• Jhernandez mentioned this in T133017: Spike: What's tested and what needs testing in Hovercards.

• Jhernandez added a project: Epic.Apr 19 2016, 9:13 AM

• Jhernandez updated the task description. (Show Details)

• Jhernandez created subtask T133018: Set up browser tests running on CI (jenkins) for Hovercards.

• Jhernandez moved this task from Needs Analysis to Goals on the Reading-Web-Sprint-70-Lady-and-the-Trumps board.Apr 19 2016, 9:18 AM

• Jhernandez added a subtask: T133019: Create browser tests for hovering link and showing hovercard.Apr 19 2016, 9:21 AM

• Jhernandez created subtask T133020: Unit test ext.popups.core.js.Apr 19 2016, 9:27 AM

• Jhernandez created subtask T133022: Unit test src/renderer.js.Apr 19 2016, 9:36 AM

• Jhernandez created subtask T133023: Unit test ext.popups.disablenavpop.js.

• Jhernandez created subtask T133024: Unit test ext.popups.logger.js.Apr 19 2016, 9:39 AM

• Jhernandez created subtask T133025: Unit test ext.popups.settings.js.Apr 19 2016, 9:41 AM