Page MenuHomePhabricator

Device detection code doesn't detect MSIE 11
Closed, ResolvedPublic

Description

See http://msdn.microsoft.com/en-us/library/ie/hh869301%28v=vs.85%29.aspx

includes/DeviceDetection.php- $deviceName = 'netfront';
includes/DeviceDetection.php- }
includes/DeviceDetection.php: } elseif ( strpos( $userAgent, 'MSIE' ) !== false ) {
includes/DeviceDetection.php- $deviceName = 'ie';

includes/DeviceDetection.php- }

javascripts/common/mf-application.js- any Firefox
javascripts/common/mf-application.js- /Firefox/,
javascripts/common/mf-application.js:
MSIE 10+
javascripts/common/mf-application.js: /MSIE 1\d/
javascripts/common/mf-application.js- ].forEach( function( item ) {
javascripts/common/mf-application.js- if ( item.test( navigator.userAgent ) ) {


Version: unspecified
Severity: minor

Details

Reference
bz65118

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:15 AM
bzimport set Reference to bz65118.
bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.May 10 2014, 8:51 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/JeFdAiDn

brion added a comment.May 10 2014, 9:04 AM

Here's some sample UAs for IE 11:

Windows 8.1 x64 desktop:
Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko

Windows 8.1 x64 metro:
Mozilla/5.0 (Windows NT 6.3; Win64; x64; Trident/7.0; rv:11.0) like Gecko

Windows Phone 8.1 x64 (emulator, my device is in other room):
Mozilla/5.0 (Windows Phone 8.1; ARM; Trident/7.0; Touch; rv:11.0; IEMobile/11.0; Microsoft; Virtual) like Gecko

brion added a comment.May 10 2014, 9:24 AM

Basically we want to detect the 'Trident' tag and find the 'rv:11.0' to extract the version.

Note that the DeviceDetection.php code from this bug report is outdated as we don't have that check anymore and mobileness check stll works properly as IE mobile 11's UAs still contain the word 'mobile'.

if I read correctly position: fixed check is still not covered.

Actually I guess we should get rid of any home made scripts here and turn to use jquery.client.

Change 133088 had a related patch set uploaded by Jdlrobson:
Support position fixed on Trident (newer IE versions)

https://gerrit.wikimedia.org/r/133088

Change 133088 merged by jenkins-bot:
Cleanup and improve supportsPositionFixed

https://gerrit.wikimedia.org/r/133088