A colon in a file name is forbidden on a windows machine.
When a repository contains one or more files with a colon in its name, cloning of that repository fails.
Please add a pre commit hook to avoid adding files with a colon in its name.
Maybe there are more letters to ignore. Thanks.
See Also:
T67139: Rename test files with colon to a proper name (invalid sign on windows machine)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T67140 Prevent the addition of files with names that aren't supported on Windows | |||
| Declined | None | T101511 common job for all repositories that runs structural linting | |||
| Declined | None | T111181 use one job for all CI entry points |
I wonder if this wouldn't be better implemented as a linter? I remember this was also a problem when there were files named like '*.wikimedia.org' that had something to do with the domains somewhere in operations repo.
The following characters are not allowed in Windows file names:
\ / : * ? " < > |
Note both kinds of slashes as directory separators.
The issue is affected CommonsMetadata (bug 65139). I am not sure it is worth triggering a job for every single patchset being sent just to catch it.
This could be something added to Arcanist when we switch to Phabricator for code review.
I am declining this one, mostly because I have no clue how we can enforce it on all repositories.