Page MenuHomePhabricator

VisualEditor: The "Review your changes" button should be disabled when save dialog is busy
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Make some edit
3.Click on Save Page on the Save page dialog
4.While loading bar is in progress click on "Review your changes"

Observed Result:
It opens up the Review section while the loading bar is still showing up above and below the dialog.

Environment:Betalabs,test2 and production


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz65310

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:10 AM
bzimport set Reference to bz65310.
  • Bug 65485 has been marked as a duplicate of this bug. ***

It doesn't do anything while the dialog is pending now. Should we be marking it as disabled though?

Change 171474 had a related patch set uploaded by Alex Monk:
Disable review button while save dialog is pending

https://gerrit.wikimedia.org/r/171474

Change 171474 merged by jenkins-bot:
Disable review button while save dialog is pending

https://gerrit.wikimedia.org/r/171474