Page MenuHomePhabricator

Standardise on our grey colours
Closed, ResolvedPublic

Description

There are still various shades of gray that don't match with one of the predefined ones in variables.less

Let's review these and sort this out.


Version: unspecified
Severity: normal

Details

Reference
bz65381

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:15 AM
bzimport set Reference to bz65381.

Whoever works on this:
You will need to audit all our existing grays, replace them with variables and then replace the non-standard ones with the ones defined in core resources/src/mediawiki.less/mediawiki.ui/variables.less

Are you saying that if '#cacaca' is not defined in either variables.less file, then replace it with the closest color, which might be '#ccc'?

Change 164488 had a related patch set uploaded by Bmansurov:
WIP: Standardize grey colors

https://gerrit.wikimedia.org/r/164488

Not quite.. I'm suggesting that if we use #cacaca somewhere we should capture it in a meaningful variable name based on how it is being used and put it in our variables file

e.g. iconOverlayText: #cacaca

The next step would then be to chat to either Moiz, Kaity (who might want to defer to May) about changing those to use one of the standard colours in the color palette.

You'll need to okay any colour changes with one of them. #ccc may be a suitable replacement for #cacaca but I can't say! :)

Change 164488 merged by jenkins-bot:
Standardize grey colors

https://gerrit.wikimedia.org/r/164488

Change 165151 had a related patch set uploaded by Bmansurov:
Standardize grey colors

https://gerrit.wikimedia.org/r/165151

(In reply to Bahodir Mansurov from comment #2)

Are you saying that if '#cacaca' is not defined in either variables.less
file, then replace it with the closest color, which might be '#ccc'?

Hey Bahodir,

Reason Jon might say that #ccc might not be a suitable replacement for #cacaca is because for example, we have placeholder text standardized at #aaa. You can see a short list here https://trello.com/c/IRqbu8p4/15-color-swatches

Since the point of this bug is for standardization purposes, depending on what #cacaca is used for, there might already be a gray assigned to that usage. Let me know if I can help you in any way!

Thanks, May. I and Kaity have already converted the colors. ;)

This is done.