Page MenuHomePhabricator

User::pingLimiter should have per action profiling
Closed, ResolvedPublic

Description

User::pingLimiter() let us limit some actions (default: 'edit'). The wfProfileIn() entry point does not vary by action. The related statsd metric generated on Wikimedia cluster is MediaWiki.User.pingLimiter

We had an incident beginning of May 2014 which had some thumb rendering action being limited. Having a graph dedicated to that action would have help spot the action being throttled.

We can probably just:

wfProfileIn( METHOD );
wfProfileIn( METHOD . '-' . $action );

Context:

https://wikitech.wikimedia.org/wiki/Incident_documentation/20140503-Thumbnails


Version: unspecified
Severity: enhancement

Details

Reference
bz65477

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:22 AM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz65477.
bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.May 19 2014, 10:38 AM

Change 134067 had a related patch set uploaded by Hashar:
User::pingLimiter() profiles per action as well

https://gerrit.wikimedia.org/r/134067

Change 134067 merged by jenkins-bot:
User::pingLimiter() profiles per action as well

https://gerrit.wikimedia.org/r/134067