Page MenuHomePhabricator

Cannot switch to VisualEditor after a reload
Closed, ResolvedPublic

Description

Could have sworn I raised this bug previously but here we go again..
Load Article#editor/0 in alpha
See VisualEditor.
Switch to source editor.
Now refresh the page using browser.
Wikitext editor loads.
Attempt to switch to VisualEditor.
Fail.


Version: unspecified
Severity: normal

Details

Reference
bz65506

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:24 AM
bzimport added a project: MobileFrontend-alpha.
bzimport set Reference to bz65506.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/FcXnAItk

jgonera wrote:

Can't reproduce on latest master.

Works for me. Tested in Firefox on latest master.

So actually I've noticed it does actually load eventually but it takes 6 seconds to do so and doesn't show a loading overlay or anything so it's not clear the click did anything...

I'm guessing you guys just have super fast instances...

jgonera wrote:

It takes about half a second on my vagrant instance, but the indication (loader) should probably appear earlier.

I don't see any indicator whatsoever for those 5 seconds so usually click it more than once :-(

A few times I've also seen two toolbars get created.

On my local instance it takes 2-3 seconds for VE to load cold but the spinner appears almost instantly.

jgonera wrote:

I'm marking as workforsome, please raise another bug if there are problems with the spinner.

It's not just the spinner - just sometimes it doesn't even start loading. I'm worried this indicates some bigger kind of problem. Let me attach some videos demonstrating the behaviour I am seeing...

Created attachment 15463
Delay between clicking button and seeing VE

Attached:

Created attachment 15464
Double toolbar loading in VE

Attached:

Best way to simulate this... Open wikitext editor via clicking edit icon.
Kill your web server.
Click the toggle to VE icon.
Nothing happens.

Change 136249 had a related patch set uploaded by Jdlrobson:
WIP: have a standard way of invoking loader

https://gerrit.wikimedia.org/r/136249

Change 137251 had a related patch set uploaded by Jdlrobson:
Show a spinner when switching between editors

https://gerrit.wikimedia.org/r/137251

Change 137251 abandoned by Jdlrobson:
Show a spinner when switching between editors

Reason:
I'm going to do this another way.

https://gerrit.wikimedia.org/r/137251

Change 137731 had a related patch set uploaded by Jdlrobson:
Show loader when switching between editors

https://gerrit.wikimedia.org/r/137731

Change 137731 merged by jenkins-bot:
Show loader when switching between editors

https://gerrit.wikimedia.org/r/137731