Page MenuHomePhabricator

Missing messages on account creation
Closed, ResolvedPublic

Description

Author: swalling

Description:
Some key interface messages seem to have disappeared on the account creation form. Specifically, MediaWiki:Createacct-helpusername and MediaWiki:Createacct-imgcaptcha-help are both gone.

Checking English Wikipedia and MediaWiki.org with uselang=qqx shows that these messages are still in the code, but are not being displayed for some reason.

This is really bad, since Createacct-imgcaptcha-help links to the local help pages for users who have accessibility issues and can't read the CAPTCHA.

Perhaps the transition to JSON screwed something up here?


Version: unspecified
Severity: normal

Details

Reference
bz65514

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz65514.
bzimport created this task.May 20 2014, 2:25 AM

swalling wrote:

Full list of messages not showing, but which are present in WikimediaMessages still:

createacct-helpusername-url
createacct-helpusername
createacct-captcha-help-url
createacct-imgcaptcha-help

Isn't a bug, see:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47801

Messages createacct-helpusername-url and createacct-captcha-help-url removed completly from core messages, createacct-helpusername and createacct-captcha-help are empty for compatibility, see changes:
https://gerrit.wikimedia.org/r/#/c/61395/
https://gerrit.wikimedia.org/r/#/c/64204/1/languages/messages/MessagesEn.php

Wikimedia-Wikis uses custom Message files (not in core), where these messages added:
https://gerrit.wikimedia.org/r/#/c/62570/

These messages aren't core messages, so sysops have to set, translate and edit these themselves.

Kind regards
Florian

swalling wrote:

(In reply to florian.schmidt.welzow from comment #2)

Isn't a bug, see:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47801

Messages createacct-helpusername-url and createacct-captcha-help-url removed
completly from core messages, createacct-helpusername and
createacct-captcha-help are empty for compatibility, see changes:
https://gerrit.wikimedia.org/r/#/c/61395/
https://gerrit.wikimedia.org/r/#/c/64204/1/languages/messages/MessagesEn.php

Wikimedia-Wikis uses custom Message files (not in core), where these
messages added:
https://gerrit.wikimedia.org/r/#/c/62570/

These messages aren't core messages, so sysops have to set, translate and
edit these themselves.

Kind regards
Florian

Yes, they're blank *in core* but they're not blank in WikimediaMessages. That extension should be delivering these messages, which is why the bug is under that component.

Ah, sorry, not seen! :) I look into.

Message createacct-helpusername and createacct-imgcaptcha-help already set in languages/i18n/en.json to avoid display of message name in <> when no WikimediaMessages installed, so in my opinion no core change. I'm unsure, that in this case anything can do :/ Maybe someone other. As a local fix for your installation you can edit the en.json and delete the message declaration (both are empty).

createacct-helpusername-url and createacct-captcha-help-url only used internally in WikimediaMessages, there isn't any problem, they will show in createacct-helpusername and createacct-imgcaptcha-help.

(In reply to florian.schmidt.welzow from comment #2)

These messages aren't core messages, so sysops have to set, translate and
edit these themselves.

WikimediaEvents is handled at TranslateWiki; e.g. https://translatewiki.net/wiki/MediaWiki:Wmf-createacct-helpusername-url/es , just like regular extensions (the one exception being it uses a special prefix so it doesn't conflict with core's message name).

Change 134561 had a related patch set uploaded by Legoktm:
Remove empty messages and ensure they exists before parse

https://gerrit.wikimedia.org/r/134561

Siebrand, since the old way stopped working, does the MessageCache::get hook seem like a good way to solve this?

We could have e.g. wmf-createacct-helpusername-url be the actual key (right now the real key is "createacct-helpusername-url", like in core; it's just considered wmf-createacct-helpusername-url on TranslateWiki), and have the MessageCache::get hook swap the keys out.

(In reply to Matthew Flaschen from comment #9)

Siebrand, since the old way stopped working, does the MessageCache::get hook
seem like a good way to solve this?

This is the approach I'm going with. See also my comment at https://gerrit.wikimedia.org/r/#/c/134561/

Change 137528 had a related patch set uploaded by Mattflaschen:
Fix Wikimedia overrides of core messages

https://gerrit.wikimedia.org/r/137528

Change 137528 merged by jenkins-bot:
Fix Wikimedia overrides of core messages

https://gerrit.wikimedia.org/r/137528

Change 134561 abandoned by Florianschmidtwelzow:
Remove empty messages and ensure they exists before parse

Reason:
See Ib39937a440e71ae7292cf992ab37a569189741e4 as a possible solution for this bug

https://gerrit.wikimedia.org/r/134561