Page MenuHomePhabricator

Create EntityChangeFactory
Closed, ResolvedPublic

Description

Currently, EntityChange instances are created by EntityChange::newFromUpdate, which uses global state to get en EntityFactory instance. We shoudl avoid this by moving the logic into a dedicated EntityChangeFactory object. This would also move the repo-specific logic out of EntityChange itself.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=3 s=2014-06-17

Details

Reference
bz65594

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:11 AM
bzimport set Reference to bz65594.
bzimport added a subscriber: Unknown Object (MLST).
daniel created this task.May 21 2014, 4:53 PM

Change 140709 had a related patch set uploaded by Daniel Kinzler:
Introducing EntityChangeFactory.

https://gerrit.wikimedia.org/r/140709

Change 140709 merged by jenkins-bot:
Introducing EntityChangeFactory.

https://gerrit.wikimedia.org/r/140709