Page MenuHomePhabricator

VisualEditor: [Regression wmf6] Hovering over any right aligned and frameless image throws error:Uncaught TypeError: Cannot read property 'getSurface' of null
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a oage with VE
2.Insert an image
3.Make it right aligned and framless
4.Hover over it

Observed Result:
It throws the following error:
Uncaught TypeError: Cannot read property 'getSurface' of null


Version: unspecified
Severity: normal

Details

Reference
bz65616

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:13 AM
bzimport set Reference to bz65616.

It also happens for the following case:

  1. Change alignment of any image
  2. Delete the image
  3. Observe that, the phantom of the image is still there after deleting the image

4.Now hover over the phantom

Observed Result:
As soon as you delete the image the error: Cannot read property 'getSurface' of null appears, also everytime you hover over the phantom , you will get this same error.

See the screenshot attached

Created attachment 15455
Screenshot

Attached:

Screen_Shot_2014-05-21_at_10.56.12_PM.png (763×815 px, 144 KB)

Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363

Fixed and backport going out in SWAT.

Change 134363 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Merge protected node into focusable node

https://gerrit.wikimedia.org/r/134363

Verified the fix in Betalabs and test 2

Verified the fix in production.

Change 134363 merged by jenkins-bot:
[BREAKING CHANGE] Merge ProtectedNode into FocusableNode

https://gerrit.wikimedia.org/r/134363