Page MenuHomePhabricator

Make CentralAuth an optional dependency
Closed, ResolvedPublic

Description

Currently, CentralAuth is documented as a hard dependency. RingtailedFox expressed interest in installing GettingStarted, but CA was a potential issue. Other people have may the same concern, so it would be good to explicitly make it optional.

Ideally, we should:

  • Either auto-detect CentralAuth (may need to use ExtensionFunctions or something so include order isn't an issue) or just have a variable, and register the appropriate hooks.
  • Have the same behavior (adding ?gettingStartedReturn=true and showing modal) either way.

And then we can document it as not required.


Version: master
Severity: enhancement

Details

Reference
bz65619

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz65619.

Sorry, meant to file as GettingStarted.

Change 135886 had a related patch set uploaded by Mattflaschen:
Create PostLoginRedirect Hook for changing the redirect behavior

https://gerrit.wikimedia.org/r/135886

Change 135888 had a related patch set uploaded by Robmoen:
Optionally depend on CentralAuth's redirect hook

https://gerrit.wikimedia.org/r/135888

Change 135886 merged by jenkins-bot:
Create PostLoginRedirect Hook for changing the redirect behavior

https://gerrit.wikimedia.org/r/135886

Change 135888 merged by Phuedx:
Optionally depend on CentralAuth's redirect hook

https://gerrit.wikimedia.org/r/135888