Page MenuHomePhabricator

Tipsy (jquery.tipsy) should disappear on click
Closed, ResolvedPublic

Description

As a user, when a Tipsy thingy covers something I want to click (like the "edit") button, I want it to disappear immediately by clicking it, without having to wait an undeterminate amount of time.


Version: master
Severity: normal

Details

Reference
bz65664

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:16 AM
bzimport set Reference to bz65664.
bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.May 23 2014, 6:19 AM

Example on attachment 15460.

UniversalLanguageSelector has already a trigger to hide tipsy after click on it:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector/e3a480205c7cf5ce93f8bcb1c20868e2e54801cb/resources%2Fjs%2Fext.uls.interface.js
lin 301.

The sam tipsy function "hide" as used in timer, so no bug in tipsy itself (it hides after timer expired) i think.

(In reply to Florian from comment #2)

The sam tipsy function "hide" as used in timer

But that's not what I asked. I don't care about timers. Any reason not to satisfy the request in core?

(In reply to Nemo from comment #3)

(In reply to Florian from comment #2)
I don't care about timers. Any reason not to

I understand you ;)

satisfy the request in core?

tipsy has the function hide, which can be triggered in Extension (like in code of UniversalLanguageSelector). Now the problem is, in my opinion, that the hideTipsy function isn't triggered when clicked on the tipsy :)

That's my view on the problem.

Change 135010 had a related patch set uploaded by Florianschmidtwelzow:
Fix close tipsy on click

https://gerrit.wikimedia.org/r/135010

It's an error in uls, not in core. The hide was on click listener of uls-trigger, not on the tipsy itself. So, no need to change anything in core :) (not every tipsy has to close on click :))

Change 135010 merged by jenkins-bot:
Close the tipsy tooltip when clicked on it

https://gerrit.wikimedia.org/r/135010