Page MenuHomePhabricator

Fatal when revdeleting old version of image
Closed, ResolvedPublic

Description

Author: tlsuda

Description:
Whenever I attempt to delete a revision of an image (as I successfully have in the past) the error message comes up. I noticed this beginning on 22 May 2014. The error message that is included reads:

PHP fatal error in /usr/local/apache/common-local/php-1.24wmf5/includes/revisiondelete/RevisionDelete.php line 642:
Cannot access protected property RevDelFileList::$deleteBatch


Version: 1.24rc
Severity: major

Details

Reference
bz65733

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz65733.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.May 25 2014, 1:30 AM

Change 135286 had a related patch set uploaded by Brian Wolff:
Revert "Pass phpcs-strict on includes/revisiondelete/"

https://gerrit.wikimedia.org/r/135286

I just proposed a revert for the offending revision. I suppose if I was better I would try to find out all the offending line and propose a fix for just that, but I'm lazy right now and the original patch was not a functional change so its not like its an urgent fix its reverting.

tlsuda wrote:

I should've checked this before, but you cannot RevDel to delete old revisions of an image, but you can RevDel the summary and the editor's username/ip address. (Also thanks Brian for categorizing this correctly for me)

Change 135286 merged by jenkins-bot:
Revert "Pass phpcs-strict on includes/revisiondelete/"

https://gerrit.wikimedia.org/r/135286

tlsuda wrote:

Issue still persists.

PHP fatal error in /usr/local/apache/common-local/php-1.24wmf5/includes/revisiondelete/RevisionDelete.php line 642:
Cannot access protected property RevDelFileList::$deleteBatch

hoo added a comment.May 26 2014, 2:31 AM

(In reply to TLSuda from comment #5)

Issue still persists.

PHP fatal error in
/usr/local/apache/common-local/php-1.24wmf5/includes/revisiondelete/
RevisionDelete.php line 642:
Cannot access protected property RevDelFileList::$deleteBatch

That's because the changed hasn't yet been deployed, but the bug still is fixed on master.

Change 135388 had a related patch set uploaded by Legoktm:
Revert "Pass phpcs-strict on includes/revisiondelete/"

https://gerrit.wikimedia.org/r/135388

Change 135389 had a related patch set uploaded by Legoktm:
Revert "Pass phpcs-strict on includes/revisiondelete/"

https://gerrit.wikimedia.org/r/135389

I've submitted backports for this and added it to the SWAT schedule for Tuesday (Monday is a holiday so no deploys) https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=114318&oldid=114279

Change 135388 merged by jenkins-bot:
Revert "Pass phpcs-strict on includes/revisiondelete/"

https://gerrit.wikimedia.org/r/135388

Change 135389 merged by jenkins-bot:
Revert "Pass phpcs-strict on includes/revisiondelete/"

https://gerrit.wikimedia.org/r/135389

Deployed by Anomie, and I've verified it's working on wmf5 and wmf6 wikis.

Apparently I don't have the ability to toggle the backport_wmf flag to +, so someone else will have to do that.