Page MenuHomePhabricator

update.php: Time taken is incorrect when the upgrade takes 1 hour or more
Closed, ResolvedPublic

Description

I was looking back at a change I reviewed and realized that a subsequent patch set (commit fae8daa658c1) does not correctly report durations of 1 hour or more. For example, if the upgrade takes 4567 seconds (1 hour 16 minutes 7 seconds), the "Done in [...]" message would include:

var_dump((new MWTimestamp)->diff(new MWTimestamp(time()-4567))->format('%i:%S'));

string(5) "16:07"


Version: 1.24rc
Severity: trivial

Details

Reference
bz65772

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:23 AM
bzimport added a project: MediaWiki-Installer.
bzimport set Reference to bz65772.

Change 135433 had a related patch set uploaded by PleaseStand:
update.php: Correctly report durations >= 1 hour

https://gerrit.wikimedia.org/r/135433

Change 135433 had a related patch set uploaded (by PleaseStand):
update.php: Correctly report durations >= 1 hour

https://gerrit.wikimedia.org/r/135433

Change 135433 merged by jenkins-bot:
update.php: Correctly report durations >= 1 hour

https://gerrit.wikimedia.org/r/135433

PleaseStand closed this task as Resolved.May 1 2015, 2:16 AM

Change was merged.