Page MenuHomePhabricator

References drawer doesn't work after editing
Closed, ResolvedPublic

Description

Author: jgonera

Description:
Edit a page with references, click on a reference after saving your edit.

Expected: see reference drawer
Result: #cite_note-1 appended in the URL, nothing happens


Version: unspecified
Severity: normal

Details

Reference
bz65816

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:09 AM
bzimport set Reference to bz65816.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.May 27 2014, 4:38 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/P8B6FH4m

In bet mode the references are handeled by mf-toggle-dynamic (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/b94649e6ae9d0a3d02c002873ac29046cb1f1dc2/javascripts/modules/mf-toggle-dynamic.js). I'm don't know, how the roadmap is, but maybe we can wait, until mf-toggle-dynamic is enabled in stable?

References appear to be enabled only when the events section-rendered or references-loaded events are run.

I suspect these are not being run.

@Juliusz what are your thoughts on the toggle-dynamic code? Basically it just defers loading of images inside sections.

We could either kill it outright to simplify things or we should push it to stable (I am leaning towards killing the code for the time being since it was written with the pretense we would be loading all sections on mobile via JavaScript and only serving the lead section in the HTML).