Page MenuHomePhabricator

ZeroBanner should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: unspecified
Severity: normal

Details

Reference
bz65817

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:09 AM
bzimport added a project: ZeroBanner.
bzimport set Reference to bz65817.
bzimport added a subscriber: Unknown Object (MLST).

NOTE the repository is a fork of mediawiki/extensions/ZeroRatedMobileAccess which has a similar bug: bug 61647. Might want to fix the parent repository first.

See also Bug 65818 - ZeroPortal should pass jshint

Change 135586 had a related patch set uploaded by Hashar:
Trigger ZeroBanner and ZeroPortal jobs

https://gerrit.wikimedia.org/r/135586

Change 135586 merged by jenkins-bot:
Trigger ZeroBanner and ZeroPortal jobs

https://gerrit.wikimedia.org/r/135586

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

No reply to comment 4 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.