The OAI repository tests can be run in Jenkins because the extension is missing an entry point and is not compatible with sqlite.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz65895
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make OAI phpunit job voting, use generic job | integration/config | master | +1 -4 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T60772 common gating job for mediawiki core and extensions | |||
| Resolved | hashar | T69216 Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking) | |||
| Resolved | None | T67874 MediaWiki extensions with failing phpunit tests (tracking) | |||
| Resolved | Legoktm | T67895 OAI does not pass Jenkins tests (sqlite compatibility) |
Event Timeline
Comment Actions
Change 136105 had a related patch set uploaded by Hashar:
Adds OAI.php default entry for unit tests
Comment Actions
We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.
Comment Actions
Not sure how to fix that one. The OAI updates table has a ut_page as a primary key and ut_sequence with auto_increment. Seems SQLite only supports auto_increment on primary key.
OAI is quite stable, does not have any tests and is supposed to be phased out eventually. Thus I am lowering the priority of this bug.
Comment Actions
There seems to be quite a bit of functionality in the extension we don't use. There isn't an updates table in production...
mysql:wikiadmin@db1038 [oai]> show tables;
+---------------+
| Tables_in_oai |
+---------------+
| oaiaudit |
| oaiuser |
+---------------+
2 rows in set (0.00 sec)
mysql:wikiadmin@db1038 [oai]>
Comment Actions
What's the issue here, this extension doesn't even have tests? If you want schema updates to work, fine, but it's not blocking the migration in any way because Jenkins will test the DB and schema update method not used in production.
Comment Actions
Change 149200 had a related patch set uploaded by MaxSem:
Add SQLite support to make Jenkins happy
Comment Actions
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment Actions
Change 207368 had a related patch set uploaded (by Legoktm):
Make OAI phpunit job voting, use generic job