Page MenuHomePhabricator

Don't give warning for extra translated units if they're blank
Open, LowPublic

Description

I had to shift a right hand unit down several units to match the left side and in the end when I saved there were many excess blank units on right hand, so I got the message "Extra units might be present. Please match the source and translation units properly". If they're all empty no harm is done, they should just be ignored.

It's very quick and obvious to delete them though, so this is not important.


Version: master
Severity: enhancement

Details

Reference
bz65901

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:15 AM
bzimport set Reference to bz65901.
Nemo_bis created this task.May 29 2014, 5:08 PM

pr4tiklahoti wrote:

The check under question is:

if ( noOfSourceUnits < noOfTranslationUnits ) {

I see two options here:

  1. Remove that check itself and Save the messages matched by the user. The logic used is simple - it picks the translation one by one in the order they appear in HTML and saves them. So this would work.
  1. Add a function before that check which will decrement the variable noOfTranslationUnits if both source and target text are empty.

Please let me know which one is better.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2015, 4:37 PM