Page MenuHomePhabricator

VisualEditor: Media settings dialog shows two selected values of alignment if you unchecking then checking the wrap option
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Insert an image of any type

2.Uncheck the wrap option

3.Check the wrap option again

4.Checking the wrap option automatically selects the "Right" as alignment again

5.Now click on one of the other alignment option:Centre/Left

Observed Result:

The alignment tab for "Right" is still selected, also the new one of step 5


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz65916

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz65916.
Ryasmeen created this task.May 29 2014, 9:47 PM

Also, if you set the image type to Basic, the alignment checkbox will behave really strangely:

  1. Set image type to basic
  2. Checkbox is unticked, left/center/right toggle is disabled
  3. Click checkbox. Checkbox is ticked and immediately unticked again, but left/center/right toggle is now enabled.
  4. Click Left. Checkbox is ticked
  5. Untick checkbox. Toggle is now disabled again

Go home alignment widget, you're drunk.

Change 137524 had a related patch set uploaded by Mooeypoo:
[wip] Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/137524

Change 137729 had a related patch set uploaded by Catrope:
Allow programmatic selection of options while disabled

https://gerrit.wikimedia.org/r/137729

Change 137729 merged by jenkins-bot:
Allow programmatic selection of options while disabled

https://gerrit.wikimedia.org/r/137729

Change 137524 merged by jenkins-bot:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/137524

Change 138122 had a related patch set uploaded by Jforrester:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/138122

Change 138122 merged by jenkins-bot:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/138122

Verified the fix in Betalabs

Verified the fix in test2 running wmf9

Verified the fix in production (en.wiki)