Page MenuHomePhabricator

VisualEditor: Clicking on Edit link beside a section heading does not take user to that specific heading rather takes to the beginning of the article
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Click on the Edit/Edit Beta link beside a section heading of an article

Observed Result:
It places the cursor at the beginning of the document .


Version: unspecified
Severity: normal

Details

Reference
bz65928

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:17 AM
bzimport set Reference to bz65928.
Ryasmeen created this task.May 30 2014, 1:13 AM

It seems like the dm.Surface's selection is getting set to the beginning of the section like it should be, but then when the ce/ui.Surface is intialized, the cursor isn't put there. It seems the surface isn't focused correctly on init anyway, and as soon as you interact with it SurfaceObserver will notice the cursor is at (1,1) and change the DM selection to that.

Change 139677 had a related patch set uploaded by Esanders:
Wait for onDocumentFocus to happen before setting section range

https://gerrit.wikimedia.org/r/139677

Change 139677 merged by jenkins-bot:
Wait for onDocumentFocus to happen before setting section range

https://gerrit.wikimedia.org/r/139677

Verified the fix in Betalabs

Not fixed for Firefox , there is no cursor at all pointing anywhere in the document after clicking on Edit link for section editing.

Probably a deployment issue; fixed on MW.org and test2.

This is still happening on FireFox in Betalabs running from master.

WFM; cache issue, it appears.

Verified the fix in production. There is a different issue with cursor now though
which has been reported in:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67106

(In reply to Tony Thomas from comment #11)

This still happens. Check
https://www.mediawiki.org/w/index.
php?title=WYSIWYG_editor&veaction=edit&vesection=18 from chrome !

Eugh, there seems to be a regression here when clicked on the page; if you click that link it works fine… As such, rather than re-opening I've created bug 72919 for this. Thanks for the spot.