Page MenuHomePhabricator

Review all uses of EntityContent::getEntity()
Closed, ResolvedPublic

Description

Once EntityContent can represent a redirect, EntityContent::getEntity() may fail when called on a redirect. All uses of that method need to be reviewed, removed or guarded against redirects.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=8 s=2014-06-17

Details

Reference
bz66030

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:24 AM
bzimport set Reference to bz66030.
bzimport added a subscriber: Unknown Object (MLST).
daniel created this task.Jun 2 2014, 1:26 PM

expected result:

  • simple calls are changed
  • separate tickets are filed for complex cases

Change 139390 had a related patch set uploaded by Daniel Kinzler:
Check for redirect before calling getEntity().

https://gerrit.wikimedia.org/r/139390

Change 139390 merged by jenkins-bot:
Check for redirect before calling getEntity().

https://gerrit.wikimedia.org/r/139390