Page MenuHomePhabricator
Create Task
Maniphest T68049

[scap] Add a command line flag to replace DOLOGMSGNOLOG
Closed, ResolvedPublic
Actions

Description

Rather than relying on a magic environment variable to block irc announcements of file syncs we should have a command line argument for all scap family scripts to disable scap.cli.Application.announce() broadcasting.

Version: wmf-deployment
Severity: normal

Details

Reference
bz66049

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:25 AM
• bzimport added a project: Deployments.
• bzimport set Reference to bz66049.
• bzimport added a subscriber: Unknown Object (MLST).
bd808 created this task.Jun 2 2014, 9:07 PM
hashar added a comment.Jun 2 2014, 9:12 PM

I have bikeshedded a bit with Bryan about it. Potentially we could:

  • deprecates DOLOGMSGNOLOG
  • support an option such as --secret
  • maybe supports SCAP_SECRET
greg moved this task from To Triage to Backlog (Tech) on the Deployments board.Dec 8 2014, 9:18 PM
greg edited projects, added scap2; removed Deployments.Feb 9 2016, 11:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2016, 11:34 PM
hashar unsubscribed.Jul 23 2016, 10:01 PM
hashar subscribed.
hashar unsubscribed.
• mmodell edited projects, added Scap; removed scap2.Feb 10 2017, 6:22 PM
• mmodell moved this task from Needs triage to Tech Debt Sprint FY201718-Q2 on the Scap board.Oct 2 2017, 4:18 PM
• mmodell edited projects, added Scap (Tech Debt Sprint FY201718-Q2); removed Scap.
• demon moved this task from Backlog to It's happening on the Scap (Tech Debt Sprint FY201718-Q2) board.Oct 16 2017, 9:18 PM
• demon mentioned this in rMSCA479b707f963d: Remove support for DOLOGMSGNOLOG environment variable.Oct 19 2017, 11:32 PM
• demon closed this task as Resolved.Oct 20 2017, 10:57 PM
• demon claimed this task.
• demon added subscribers: hashar, • demon.
In T68049#712815, @hashar wrote:

I have bikeshedded a bit with Bryan about it. Potentially we could:

  • deprecates DOLOGMSGNOLOG
  • support an option such as --secret
  • maybe supports SCAP_SECRET

Went with --no-log-message. The old env variable, DOLOGMSGNOLOG still works for now for back-compat, but emits a warning if used. We'll drop that back-compat in the next release after this one, probably.

greg added a project: Release-Engineering-Team (Kanban).Oct 20 2017, 11:06 PM
• Phabricator_maintenance edited projects, added RelEng-Archive-FY201718-Q2; removed Release-Engineering-Team (Kanban).Dec 21 2017, 6:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits