Page MenuHomePhabricator

[scap] Add a command line flag to replace DOLOGMSGNOLOG
Closed, ResolvedPublic

Description

Rather than relying on a magic environment variable to block irc announcements of file syncs we should have a command line argument for all scap family scripts to disable scap.cli.Application.announce() broadcasting.


Version: wmf-deployment
Severity: normal

Details

Reference
bz66049

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:25 AM
bzimport added a project: Deployments.
bzimport set Reference to bz66049.
bzimport added a subscriber: Unknown Object (MLST).

I have bikeshedded a bit with Bryan about it. Potentially we could:

  • deprecates DOLOGMSGNOLOG
  • support an option such as --secret
  • maybe supports SCAP_SECRET
hashar added a subscriber: hashar.
hashar removed a subscriber: hashar.
demon claimed this task.
demon added subscribers: hashar, demon.

I have bikeshedded a bit with Bryan about it. Potentially we could:

  • deprecates DOLOGMSGNOLOG
  • support an option such as --secret
  • maybe supports SCAP_SECRET

Went with --no-log-message. The old env variable, DOLOGMSGNOLOG still works for now for back-compat, but emits a warning if used. We'll drop that back-compat in the next release after this one, probably.