Page MenuHomePhabricator

Deploy Mantle extension to WMF servers
Closed, ResolvedPublic

Description

Flow and MobileFrontend want to share code that is not quite ready for MediaWiki core (core/mantle - get it?). One big example is sharing of delivering of client side templates via ResourceLoader.

MobileFrontend has been doing this for some time, and the new extension Mantle simply shuffles code from there into a standalone repository so that Flow can use it without being dependent on MobileFrontend.

Sadly this is not quite ready for core - as there has been no standardisation on a default template library.

Once deployed, MobileFrontend can add a hard dependency to Mantle by merging the following patch:
https://gerrit.wikimedia.org/r/#/c/129335/

Read more about Mantle here: https://www.mediawiki.org/wiki/Extension:Mantle

Note: The plan is also to move Nearby functionality into the GeoData extension and add a dependency on GeoData to Mantle.


Version: unspecified
Severity: enhancement

Details

Reference
bz66094

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:10 AM
bzimport set Reference to bz66094.
bzimport added a subscriber: Unknown Object (MLST).
greg added a comment.Jun 4 2014, 3:15 PM

Any new code here or just a copy/paste operation? I'm only worried because of the word "template" :)

Pretty much a cut and paste job from MobileFrontend with some renaming.

That said there are a few tweaks to the template.js file that allow different template compilers so that as well as Hogan it supports Handlebars.

I suspect if you were to find any issues with Mantle you would also find them with MobileFrontend :)

(In reply to Greg Grossmeier from comment #1)

Any new code here... ?

Yes. Besides the code that was formerly in extension MobileFrontend restructured for code sharing, this introduces the new third-party templating library Handlebars.js in Mantle/javascripts/externals/handlebars.js. That will need security review.

greg added a comment.Jun 6 2014, 4:09 AM

(In reply to spage from comment #3)

(In reply to Greg Grossmeier from comment #1)

Any new code here... ?

Yes. Besides the code that was formerly in extension MobileFrontend
restructured for code sharing, this introduces the new third-party
templating library Handlebars.js in
Mantle/javascripts/externals/handlebars.js. That will need security review.

Bug 66238

Change 142142 had a related patch set uploaded by Spage:
add new Mantle extension, required by coming Flow

https://gerrit.wikimedia.org/r/142142

gerrit 142142 is for beta labs, https://gerrit.wikimedia.org/r/#/c/142151/ is for production (Gerrit Notification Bot missed the latter?).

Change 142142 merged by jenkins-bot:
new Mantle extension on labs, required by coming Flow

https://gerrit.wikimedia.org/r/142142

tomasz added a comment.Aug 5 2014, 7:35 PM

This was done ages ago; https://en.wikipedia.org/wiki/Special:Version reports Mantle as deployed.