Page MenuHomePhabricator

VisualEditor: If you have added a category already, typing it in a second time doesn't show it in the list — except if the category is a "red link", in which case it will suggest it as a new one again
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open VE
2.Go to Page options>Categories
3.Insert a new category:Ca, it appears under matching categories section according to the change on https://bugzilla.wikimedia.org/show_bug.cgi?id=49044
4.Select the first match Ca
4.Now again type Ca

Observed Result:
This time it appears under New Category section.

see the screenshot attached


Version: unspecified
Severity: minor

Attached:

Details

Reference
bz66105

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:11 AM
bzimport set Reference to bz66105.
Ryasmeen created this task.Jun 4 2014, 12:08 AM

Change 137307 had a related patch set uploaded by Alex Monk:
Check last existing category for whether or not we're trying to re-add it

https://gerrit.wikimedia.org/r/137307

Change 137307 merged by jenkins-bot:
Check last existing category for whether or not we're trying to re-add it

https://gerrit.wikimedia.org/r/137307

Fixed. That function is full of horrible things to do with following redirects (where a supposed category is actually a redirect to another category) and categories which are marked as hidden, mostly my fault and probably full of bugs if you want to poke around with that. Particularly in cases where we're supposed to exclude suggestions due to already having the suggestion on the list.

Verified the fix in en.wiki running wmf 8