Page MenuHomePhabricator
Create Task
Maniphest T68134

Special:BookSources: Bad value 1 for attribute autofocus on element input
Closed, ResolvedPublic
Actions

Description

The rendered Special:BookSources contains:
<input name="isbn" size="20" value="" id="isbn" autofocus="1" />

which is invalid html because the autofocus should be empty.

Version: 1.24rc
Severity: minor

Details

Reference
bz66134
SubjectRepoBranchLines +/-
Fix "Bad value 1 for attribute autofocus" on special pagesmediawiki/coremaster+5 -5
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:12 AM
• bzimport added projects: MediaWiki-Special-pages, good first task.
• bzimport set Reference to bz66134.
duplicatebug created this task.Jun 4 2014, 7:43 PM
gerritbot added a comment.Jun 5 2014, 3:24 PM

Change 137670 had a related patch set uploaded by Rohan013:
Bugfix for bug 66134

https://gerrit.wikimedia.org/r/137670

gerritbot added a comment.Jun 7 2014, 6:30 AM

Change 137670 had a related patch set uploaded by devunt:
Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources

https://gerrit.wikimedia.org/r/137670

gerritbot added a comment.Jun 9 2014, 6:08 PM

Change 137670 abandoned by Rohan013:
Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources

https://gerrit.wikimedia.org/r/137670

gerritbot added a comment.Jun 9 2014, 6:30 PM

Change 137670 restored by Rohan013:
Replace autofocus="1" /> to autofocus /> on input element in Special:BookSources

https://gerrit.wikimedia.org/r/137670

gerritbot added a comment.Jun 10 2014, 9:15 AM

Change 137670 had a related patch set uploaded by devunt:
Changes autofocus="1" to autofocus="autofocus"

https://gerrit.wikimedia.org/r/137670

gerritbot added a comment.Jun 18 2014, 9:56 AM

Change 137670 abandoned by Rohan013:
[SHOULD BE ABANDONED] Changes autofocus="1" to autofocus="autofocus"

Reason:
Fixed in Ic682a60ca4a08

https://gerrit.wikimedia.org/r/137670

duplicatebug unsubscribed.Dec 13 2014, 4:16 PM
Umherirrender claimed this task.Jan 14 2015, 6:39 PM
gerritbot subscribed.Jan 14 2015, 6:39 PM

Change 184941 had a related patch set uploaded (by Umherirrender):
Fix "Bad value 1 for attribute autofocus" on special pages

https://gerrit.wikimedia.org/r/184941

Patch-For-Review

Ricordisamoa subscribed.Jan 15 2015, 12:11 AM
Ricordisamoa awarded a token.Mar 1 2015, 3:01 AM
gerritbot added a comment.Mar 18 2015, 2:35 PM

Change 184941 merged by jenkins-bot:
Fix "Bad value 1 for attribute autofocus" on special pages

https://gerrit.wikimedia.org/r/184941

Umherirrender closed this task as Resolved.Mar 18 2015, 3:56 PM
Ricordisamoa removed a project: Patch-For-Review.Mar 18 2015, 4:20 PM
Ricordisamoa set Security to None.
Nikerabbit mentioned this in rMWc89feebfd0f8: Fix "Bad value 1 for attribute autofocus" on special pages.Mar 23 2015, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL