Page MenuHomePhabricator

VisualEditor: Link inspector should catch 400 errors from sending overly-long queries to the API
Closed, ResolvedPublic

Description

This results in a quite bad outcome for the user, totally inexplicably. Instead we should just catch these errors and state them as invalid links (or have a different message?).


Version: unspecified
Severity: major
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66135

Details

Reference
bz66139

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:13 AM
bzimport set Reference to bz66139.

Gerrit change 138016 should make it so that these show invalid title warnings. Though I haven't got CirrusSearch installed on my dev wiki so haven't tested it against the request_too_long Cirrus error.

Change 138016 had a related patch set uploaded by Alex Monk:
Don't sent invalid titles from the link inspector to the API

https://gerrit.wikimedia.org/r/138016

Change 138016 merged by jenkins-bot:
Don't send invalid titles from the link inspector to the API

https://gerrit.wikimedia.org/r/138016