Page MenuHomePhabricator

VisualEditor: [Regression wmf7] Cursor is no longer getting automatically placed in the edit summary field; document isn't unfocussed in Firefox
Closed, ResolvedPublic

Description

Note: This happens in mediawiki.org (1.24wmf7 (941d0e1)), but not in en.wikipedia (1.24wmf6 (4331f6b)).

To reproduce:

  1. Edit an article. Make a change.
  2. Press "Save page".
  3. Try writing an edit summary.

Observed: The text is added to the article.

Expected: The cursor must automatically focus in the edit summary field.


Version: unspecified
Severity: major

Details

Reference
bz66168

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.
bzimport set Reference to bz66168.
Amire80 created this task.Jun 5 2014, 8:38 AM

This is concerning; bug 65222 should have fixed this from happening. What browser were you using? I can't replicate in wmf7 in Chrome, Safari or Firefox.

However, it does seem to have regressed in wmf8.

I can still reproduce it in Firefox and Chrome on mediawiki.org.

In Firefox after opening the Save dialog, if I type, the text is added to the article.

In Chrome the text doesn't seem to be added anywhere.

And what's worse, I can now also reproduce it in the English Wikipedia.

Sorry, that comment was half-written about a different bug. Bah Bugzilla.

I can indeed replicate in wmf7 and above (which is now everywhere).

Change 137926 had a related patch set uploaded by Esanders:
Move save panel init to onReady

https://gerrit.wikimedia.org/r/137926

Change 137971 had a related patch set uploaded by Jforrester:
Move save panel init to getReadyProcess

https://gerrit.wikimedia.org/r/137971

Change 137926 merged by jenkins-bot:
Move save panel init to getReadyProcess

https://gerrit.wikimedia.org/r/137926