Page MenuHomePhabricator

VisualEditor: Replace uses of push.apply with something safe
Closed, ResolvedPublic

Description

Similar to how we have ve.batchSplice for splice.apply


Version: unspecified
Severity: enhancement

Details

Reference
bz66206

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz66206.
Catrope created this task.Jun 5 2014, 6:31 PM

Change 166790 had a related patch set uploaded by SuchetaG:
Replacing push.apply with newly created ve.batchPush in VE core

https://gerrit.wikimedia.org/r/166790

Change 166799 had a related patch set uploaded by SuchetaG:
Replacing push.apply in VE-MW with ve.batchPush from VE core

https://gerrit.wikimedia.org/r/166799

Change 166790 merged by jenkins-bot:
Replacing push.apply with newly created ve.batchPush in VE core

https://gerrit.wikimedia.org/r/166790

VE-MW patch coming or not needed?

(In reply to James Forrester from comment #4)

VE-MW patch coming or not needed?

There are two usages in VE-MW that do need to be cleaned up. Now that 166790 was pulled through into VE-MW (a few minutes ago) that can be done.

(In reply to Roan Kattouw from comment #5)

(In reply to James Forrester from comment #4)
> VE-MW patch coming or not needed?

There are two usages in VE-MW that do need to be cleaned up. Now that 166790
was pulled through into VE-MW (a few minutes ago) that can be done.

Ugh somehow we missed the fact that there was a patch for this that was submitted three hours ago. We're both blind :S

Change 166799 merged by jenkins-bot:
Replacing push.apply in VE-MW with ve.batchPush from VE core

https://gerrit.wikimedia.org/r/166799