Page MenuHomePhabricator

VisualEditor: [Regression wmf8] Cannot check the wrap option after changing a Thumbnail/Frame image to Frameless/Basic
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE in test2
2.Insert an image
3.Change the image type to Frameless/Basic
4.Now observe the checkbox for wrap is now unchecked
5.Try to check the checkbox

Observed Result:
It does not check the checkbox , but all the alignment tabs becomes visible .

This is happening in test2 only,

See the screenshot attached


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz66291

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:23 AM
bzimport set Reference to bz66291.
Ryasmeen created this task.Jun 6 2014, 11:11 PM

This is happening in test2 and other wmf8 sites (like MW.org) but not wmf7s and Beta Labs, or just test2?

Yes, it is also in MW.org , but not on Betalabs , not on en.wiki.

So, its in wmf 8, not on wmf 7 and wmf 9

The patchset that fixed the wrapping textbox was merged yesterday evening. That might explain the inconsistency; it's not in mw and test2 yet.

https://gerrit.wikimedia.org/r/#/c/137524/

If this isn't happening in beta labs, it should show the patchset fixed the bug. (Correct me if I'm wrong?)

Change 138122 had a related patch set uploaded by Jforrester:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/138122

This makes for a confusing bug history. :-)

Change 138122 merged by jenkins-bot:
Fixing issues in the alignment select in Media Edit dialog

https://gerrit.wikimedia.org/r/138122

Verified the fix in test2 running wmf9

Verified the fix in production (en.wiki)