Page MenuHomePhabricator

VisualEditor: Cannot resize frame image in MediaWiki, but can in VisualEditor(?)
Closed, ResolvedPublic

Description

Author: vojtech.dostal

Description:
A student of Education program at Czech Wikipedia noticed that she cannot resize an image which is inserted as a frame. It is well possible to adjust the size in the preview mode, but saving it does not produce appropriately resized image frame.

see image under heading "Půdorys" at:
https://cs.wikipedia.org/wiki/Kostel_Nanebevzet%C3%AD_Panny_Marie_%28Charvatce%29

Thank you
Vojtěch Dostál


Version: unspecified
Severity: normal

Details

Reference
bz66353

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz66353.
bzimport created this task.Jun 8 2014, 10:34 PM

Thanks for this bug; it seems like a regression(?!) in MediaWiki. Moriel, can you confirm?

Yes, after a bit of analysis, I believe there's a problem with the way the scalable object analyzes default vs custom values. I'm working on refactoring the way that works; we have a tech debt about this, too, I believe.

Change 138388 had a related patch set uploaded by Mooeypoo:
Disable the size widget for 'frame' images

https://gerrit.wikimedia.org/r/138388

Scratch my last remark. There is still a technical debt (that is being taken care of) about default vs. custom size but the issue in this case is that we don't follow the wikitext rules properly.

Frame images ignore size specification.
See wikitext documentation here: https://www.mediawiki.org/wiki/Help:Images#Size_and_frame

Change 138388 merged by jenkins-bot:
Disable the size widget for 'frame' images

https://gerrit.wikimedia.org/r/138388