Page MenuHomePhabricator

Vector: Use standard classes like .mw-body in stylesheets instead of custom ids like #content
Closed, ResolvedPublic

Description

We are trying to apply the Vector styles to raw Parsoid output for render testing. There are a few prefixed rules that don't apply as they are overly specific to some elements and ids in the old-style HTML output. Afaik #content et al is deprecated, and the better way to do this is to match on .mw-body and .mw-body-content etc. Similar with #footer.

It would also be great if the selector didn't require a div wrapper. In Parsoid HTML the content is directly inside the body & the classes are set on the body. Things will work just fine if the selector was just on the class, without requiring a div.


Version: unspecified
Severity: normal

Details

Reference
bz66461

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:17 AM
bzimport set Reference to bz66461.
bzimport added a subscriber: Unknown Object (MLST).

Change 158854 had a related patch set uploaded (by Krinkle):
mediawiki.skinning: Use mw-body-content instead of mw-body where appropriate

https://gerrit.wikimedia.org/r/158854

Jdlrobson changed the task status from Open to Stalled.Sep 23 2015, 11:58 PM
Jdlrobson subscribed.

Timo seems to have -1ed the patch (last update June) - would be great to wrap this up.

The patch at https://gerrit.wikimedia.org/r/158854 is not relevant to the resolution of this task. We already switched away from using non-standard IDs to using standard classes.

https://gerrit.wikimedia.org/r/158854 is about using a more specific class so that Parsoid doesn't need a skin class. However that can't be done at the moment due to existence of content-like output outside the content area (e.g. sitenotice) which is expected to have the same styling.

So as far as I can tell this task is already resolved.

dr0ptp4kt claimed this task.
dr0ptp4kt subscribed.

Resolving per T68461#1669066