Page MenuHomePhabricator

Track entity redirects in a database table (associated with the wb_entity_per_page table).
Closed, ResolvedPublic

Description

When recording redirects in wb_entity_per_page, we need a column (or separate table) to hold the redirect target. This will also allow us to efficiently identifry and filter redirects when iterating over all entit


Version: unspecified
Severity: major
Whiteboard: u=dev c=backend p=0 s=2014-07-15

Details

Reference
bz66582

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:25 AM
bzimport set Reference to bz66582.
bzimport added a subscriber: Unknown Object (MLST).
daniel created this task.Jun 13 2014, 12:24 PM

...when iterating over all entity IDs.

  • Bug 66074 has been marked as a duplicate of this bug. ***

After some thought, it seems that it's more sensible to have redirect in a separate table, and remove them from wb_entity_per_page. This will assure compatibility with existing code that uses wb_entity_per_page to iterate over all entities, and it generally makes for a nicer database layout.

Adjusting the description accordingly.

We are not going to track them for now.

Needed after all.

After some back-and-forth, we decided to add a column to entity_per_page after all, see the thread on wikidata-tech startwing with http://lists.wikimedia.org/pipermail/wikidata-tech/2014-July/000540.html.

Change 147137 had a related patch set uploaded by Daniel Kinzler:
Tests for redirect handling in EntityRevisionLookup

https://gerrit.wikimedia.org/r/147137

Change 147118 merged by jenkins-bot:
Track redirects in EPP table

https://gerrit.wikimedia.org/r/147118

Change 147137 merged by jenkins-bot:
Tests for redirect handling in EntityRevisionLookup

https://gerrit.wikimedia.org/r/147137