Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf10] In Firefox, Saving the edit on a page everytime throws error: this.debugBar is null and cannot re-open VE after that
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE in Firefox
2.Go to Insert>Language
3.Close the language inspector without making any change
4.Click on "Save Page"

Observed Result:
After step 3 you get the error: TypeError: sel.nativeSelection is null
After saving there is another error in the console:
TypeError: this.debugBar is null

If you had categories add on this page, they move to the top of the page
The context menu for Language Inspector is still open in read mode
Try to reopen VE , clicking on Edit button, VE does not open.

Environment: test2 and Betalabs


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz66692

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:16 AM
bzimport set Reference to bz66692.

The second error: TypeError: this.debugBar is null
appears after selecting any language from the language selector

Change 140039 had a related patch set uploaded by Catrope:
Followup 00af434: only tear down debug bar if it exists

https://gerrit.wikimedia.org/r/140039

Change 140039 merged by jenkins-bot:
Followup 00af434: only tear down debug bar if it exists

https://gerrit.wikimedia.org/r/140039

Are you sure this is a fault for test2? The code this follows up wasn't present for wmf9 unless I'm missing something.

Sorry, the language inspector throwing "TypeError:sel.nativeSelection is null"-
this is in both test2 and betalabs,but not the issue with tearing down the debug bar.
Initially I thought both of them are related.I am opening a different bug for that one.

(In reply to ryasmeen from comment #5)

Sorry, the language inspector throwing "TypeError:sel.nativeSelection is
null"-
this is in both test2 and betalabs,but not the issue with tearing down the
debug bar.
Initially I thought both of them are related.I am opening a different bug
for that one.

OK, thanks.

Verified the fix in Betalabs

The backport did not work in test2

Ignore my last comment, added the comment on wrong bug

Verified the fix in production(en.wiki)