Page MenuHomePhabricator

Preview step of "firstedit" tour is displaying incorrectly after save
Closed, ResolvedPublic

Description

Author: swalling

Description:
Beta Labs screenshot

Steps to reproduce:

  1. Go to an article on Beta Labs with the firstedit tour enabled, like http://en.wikipedia.beta.wmflabs.org/wiki/Corgi?tour=firstedit
  1. Edit and save the page without previewing
  1. You should see the preview instructions again, unattached

Version: unspecified
Severity: normal

Attached:

Details

Reference
bz66743

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:19 AM
bzimport set Reference to bz66743.
bzimport created this task.Jun 17 2014, 9:20 PM

swalling wrote:

This does not appear to happen with the Save step.

swalling wrote:

Also tested on English Wikipedia proper, and I do not get this.

Change 143170 had a related patch set uploaded by Robmoen:
Add automatic next button step specification.

https://gerrit.wikimedia.org/r/143170

(In reply to Gerrit Notification Bot from comment #3)

Change 143170 had a related patch set uploaded by Robmoen:
Add automatic next button step specification.
https://gerrit.wikimedia.org/r/143170

This patch was mistakenly marked with the bug and is unrelated.

swalling wrote:

enwiki screenshot

Attached:

swalling wrote:

This is now appearing in production on enwiki.

You can replicate by:

  1. viewing a page with either ?tour=firstedit or the GettingStarted CTA, and then choosing "Edit this page"
  2. click Edit
  3. Go back to read mode

Change 145464 had a related patch set uploaded by Robmoen:
End tour if saving before preview

https://gerrit.wikimedia.org/r/145464

Change 145464 merged by jenkins-bot:
End tour if saving before preview

https://gerrit.wikimedia.org/r/145464

swalling wrote:

English Wikipedia screenshot

Attached:

swalling wrote:

This same issue is happening on production for the gettingstartedtasktoolbar tour. See new screenshot.

Please file a new bug against the GettingStarted extension.