Logo: add nolink attribute
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Foxtrott
	Jun 19 2014, 8:51 PM

Description

When the 'nolink' attribute is specified in the layout xml file, the logo should be just a normal image instead of a link to the wiki main page.

To ensure consistent styling it might make sense to just drop the 'href' attribute instead of removing the <a> completely. (Would this then still be valid HTML?)

Version: unspecified
Severity: enhancement

Details

Reference: bz66859

	Subject	Repo	Branch	Lines +/-
	Logo: add addLink attribute to Logo component	mediawiki/skins/chameleon	master	+17 -5

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:26 AM

• bzimport added projects: Chameleon, good first task.

• bzimport set Reference to bz66859.

Foxtrott created this task.Jun 19 2014, 8:51 PM

Haritha28 subscribed.Aug 11 2015, 12:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2015, 12:43 PM

Haritha28 claimed this task.Aug 11 2015, 12:44 PM

Haritha28 set Security to None.

I couldnt find any <a href >attribute there in the xml files. Can someone help me out ?

The link on the logo is built in Logo.php. See https://github.com/wikimedia/mediawiki-skins-chameleon/blob/master/src/Components/Logo.php

@Haritha28: This issue has been assigned to you a while ago.
Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anything that others could help with?
Only in case you do not plan to work on this issue anymore, should you be removed as assignee (via 'Reassign / Claim' in the 'Action' dropdown menu)?
Thanks for contributing to Wikimedia!