Page MenuHomePhabricator

WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct
Closed, ResolvedPublic

Description

Screenshot of mis-matched tabs

This is a bit odd. Presumably we're testing in different ways so getting different results?


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49000
https://bugzilla.wikimedia.org/show_bug.cgi?id=53774

Attached:

Details

Reference
bz66885

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:26 AM
bzimport set Reference to bz66885.

So it looks like the patch for 49000 was supposed to fix this for all special pages, but missed this one (commit message only references Special:MoveFile).

Unfortunately it basically involved guessing that the page exists when MW doesn't tell us. See also bug 53774

Changing assignee to match that bug's

Dependency now merged. Let's get this done?

Change 174582 had a related patch set uploaded by Alex Monk:
Check wgRelevantArticleId to determine relevant page existence even on special pages

https://gerrit.wikimedia.org/r/174582

Jdforrester-WMF set Security to None.
Jdforrester-WMF renamed this task from VisualEditor: WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct to WT create tab on Special:Undelete when looking at a page is changed to "Edit source" rather than "create source", but VE tab is correct.Nov 24 2014, 4:50 AM
Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Nov 25 2014, 7:29 PM

Change 174582 merged by jenkins-bot:
Check wgRelevantArticleId to determine relevant page existence even on special pages

https://gerrit.wikimedia.org/r/174582

Krenair closed this task as Resolved.Nov 25 2014, 7:45 PM

This should now work.