Page MenuHomePhabricator

VisualEditor: mw.Title invocations for template titles should use template namespace as default namespace
Closed, ResolvedPublic

Description

Right now we have things like mw.Title.newFromText( template ); , while really that should use something like mw.Title.newFromText( template, 10 ); or whatever. This is probably fine in practice, but theoretically matters is NS_MAIN and NS_TEMPLATE have different capitalization settings.

We also currently render the titles of {{foo}} (which points to Template:Foo, renders as Foo) and {{:foo}} (which points to Foo, also renders as Foo) the same, we should fix that.


Version: unspecified
Severity: normal

Details

Reference
bz66893

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz66893.
Catrope created this task.Jun 21 2014, 12:26 AM

Change 141082 had a related patch set uploaded by Jforrester:
Normalize titles in template descriptions in context menu

https://gerrit.wikimedia.org/r/141082

Change 141082 merged by jenkins-bot:
Normalize titles in template descriptions in context menu

https://gerrit.wikimedia.org/r/141082

(In reply to Roan Kattouw from comment #0)

Right now we have things like mw.Title.newFromText( template ); , while
really that should use something like mw.Title.newFromText( template, 10 );
or whatever. This is probably fine in practice, but theoretically matters is
NS_MAIN and NS_TEMPLATE have different capitalization settings.

This is not fixed yet, reopening.

We also currently render the titles of {{foo}} (which points to
Template:Foo, renders as Foo) and {{:foo}} (which points to Foo, also
renders as Foo) the same, we should fix that.

This was indeed fixed by https://gerrit.wikimedia.org/r/141082

Change 143685 had a related patch set uploaded by Catrope:
Try some more to handle template namespace properly

https://gerrit.wikimedia.org/r/143685

Change 143685 merged by jenkins-bot:
Try some more to handle template namespace properly

https://gerrit.wikimedia.org/r/143685

(In reply to Roan Kattouw from comment #3)

(In reply to Roan Kattouw from comment #0)
> Right now we have things like mw.Title.newFromText( template ); , while
> really that should use something like mw.Title.newFromText( template, 10 );
> or whatever. This is probably fine in practice, but theoretically matters is
> NS_MAIN and NS_TEMPLATE have different capitalization settings.
>
This is not fixed yet, reopening.

Somewhat to my surprise this is in fact fully fixed in https://gerrit.wikimedia.org/r/143685