Page MenuHomePhabricator
Create Task
Maniphest T68898

PageCuration: Get rid of synchronous AJAX request on page load
Closed, ResolvedPublic
Actions

Description

In ext.PageTriage.viewUtil.js, there is a synchronous AJAX request executed on page load. Firefox 30 complains about this in the JS console:

Synchronous XMLHttpRequest on the main thread is deprecated because of its
detrimental effects to the end user's experience. For more help
http://xhr.spec.whatwg.org/

Don't know why this request has to be synchronous. Code should be refactored so it can be made asynchronous.

Version: master
Severity: normal

Details

Reference
bz66898
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Deliver HTML templates using ResourceLoader rather than API callsmediawiki/extensions/PageTriagemaster+53 -181
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:27 AM
• bzimport added projects: PageTriage, Performance Issue.
• bzimport set Reference to bz66898.
• bzimport added a subscriber: Unknown Object (MLST).
TTO created this task.Jun 21 2014, 4:41 AM
Quiddity added a project: Collaboration-Team-Triage.Oct 28 2015, 1:38 AM
Quiddity removed a subscriber: • DannyH.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 28 2015, 1:38 AM
Ricordisamoa added a parent task: T90327: Remove use of synchronous XMLHttpRequest (deprecated) .Mar 19 2016, 7:19 AM
Ricordisamoa subscribed.
Krenair merged a task: T90328: PageTriage uses synchronous XMLHttpRequests.Mar 19 2016, 8:40 PM
Krenair added subscribers: EBernhardson, Krinkle.
Krinkle added a project: Technical-Debt.Mar 28 2016, 9:21 PM
Krinkle set Security to None.
Krinkle moved this task from Unsorted to Needs removal on the Technical-Debt board.
Krinkle removed subscribers: Krinkle, • wikibugs-l-list.
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Jul 13 2018, 11:10 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 13 2018, 11:10 PM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).Jul 13 2018, 11:27 PM
JTannerWMF moved this task from Inbox to Needs Discussion on the Growth-Team board.Jul 18 2018, 6:32 PM
EBernhardson unsubscribed.Jul 18 2018, 6:40 PM
gerritbot subscribed.Jul 31 2018, 9:33 PM

Change 449612 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/PageTriage@master] Deliver HTML templates using ResourceLoader rather than API calls

https://gerrit.wikimedia.org/r/449612

gerritbot added a project: Patch-For-Review.Jul 31 2018, 9:33 PM
matmarex claimed this task.Jul 31 2018, 9:33 PM
matmarex lowered the priority of this task from High to Low.
MMiller_WMF subscribed.Aug 1 2018, 5:58 PM

@matmarex -- are you in need of code review for this fix? If so, the Growth team could help. Let us know!

matmarex added a comment.Aug 1 2018, 6:02 PM

@MMiller_WMF Yes, but it's not urgent, this task is four years old and it will not hurt if it takes a few weeks to fix.

JTannerWMF moved this task from Needs Discussion to External on the Growth-Team board.Aug 1 2018, 6:03 PM
MMiller_WMF moved this task from External to Upcoming Work on the Growth-Team board.Aug 1 2018, 9:00 PM
MMiller_WMF added subscribers: SBisson, Catrope.

Okay. @Catrope or @SBisson -- it would be helpful if you review this. I'll put it in line for our next sprint so that we don't forget.

MMiller_WMF removed a project: Collaboration-Team-Triage.Aug 9 2018, 5:56 PM
MMiller_WMF moved this task from Upcoming Work to Sprint 0 (Growth Team) on the Growth-Team board.
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
JTannerWMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2018, 6:08 PM
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2018, 10:48 PM
gerritbot added a comment.Aug 16 2018, 10:55 PM

Change 449612 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Deliver HTML templates using ResourceLoader rather than API calls

https://gerrit.wikimedia.org/r/449612

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 16 2018, 11:00 PM
kostajh subscribed.Aug 17 2018, 12:37 PM

@matmarex thanks for your work on this!

Etonkovidova closed this task as Resolved.Aug 17 2018, 9:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits