Page MenuHomePhabricator

Installer can put html errors at the top of LocalSettings.php
Closed, ResolvedPublic

Description

https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Notice:_Undefined_index:_createaccount_in_C:%5Cwamp%5Cwww%5Cwiki%5Cincludes%5Cinstaller%5CLocalSettingsGenerator.php_on_line_225

Problems like this would be avoided if it weren't possible for the installer to mix error output in with LocalSettings.php


Version: 1.24rc
Severity: normal

Details

Reference
bz66922

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:28 AM
bzimport set Reference to bz66922.

Change 141261 had a related patch set uploaded by MarkAHershberger:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141261

Change 141307 had a related patch set uploaded by MarkAHershberger:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141307

Change 141307 merged by jenkins-bot:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141307

Change 141261 merged by jenkins-bot:
Don't allow some E_NOTICE messages to end up in the LocalSettings.php

https://gerrit.wikimedia.org/r/141261