Page MenuHomePhabricator

Special:ContentTranslation inserts source links as target
Closed, ResolvedPublic

Description

If a target link doesn't exist, the source link may be inserted incorrectly.

This can be fixed by removing || page.title in ext.cx.tools.link.js line 112, because if there's no page.langlinks[ 0 ][ '*' ], then there's probably no target link to insert, but then the problem is that redirects are not handled correctly: linkPairs is indexed by the real target article, while the adaptations parameter in apply() is looked up by the href, which is the name of the redirect.


Version: unspecified
Severity: normal

Details

Reference
bz66967

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:31 AM
bzimport added a project: ContentTranslation.
bzimport set Reference to bz66967.
Amire80 created this task.Jun 23 2014, 5:44 AM

Change 141379 had a related patch set uploaded by Amire80:
Don't insert source title if there's no target link

https://gerrit.wikimedia.org/r/141379

Change 141379 abandoned by Amire80:
Don't insert source title if there's no target link

Reason:
the meaningful part was merged in another patch.

https://gerrit.wikimedia.org/r/141379