Page MenuHomePhabricator
Create Task
Maniphest T69023

AJAX review errors show HTML markup in notification
Closed, ResolvedPublic
Actions

Description

screenshot of the problem

The AJAX implementation of flagged revs, returns html fragments in case of errors: <p><b>Unable to review this revision</b></p><p>Permission denied</p>.

This textual html fragment is passed straight to mw.notify, but mw.notify can only handle: HTML dom, jQueryElements, a message key or plain text.

Version: master
Severity: normal

Attached:

Blocked_reviewer_error_message.jpeg (271×415 px, 42 KB)

Details

Reference
bz67023

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
InvalidNoneT40638 [DO NOT USE] Interface messages needing rewording or documentation and other issues with existing messages [superseded by #Voice_&_Tone]
ResolvedFomafixT69023 AJAX review errors show HTML markup in notification
· · ·

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:35 AM
• bzimport added a project: MediaWiki-extensions-FlaggedRevs.
• bzimport set Reference to bz67023.
TheDJ created this task.Jun 24 2014, 9:02 AM
Schnark added a comment.Jul 5 2014, 7:48 AM
  • Bug 67484 has been marked as a duplicate of this bug. ***
Umherirrender added a comment.Jul 5 2014, 8:20 AM

Affected message key for better search result: 'revreview-failed'

gerritbot added a comment.Aug 6 2014, 10:34 PM

Change 152186 had a related patch set uploaded by Bartosz Dziewoński:
Parse HTML in JavaScript failure notices

https://gerrit.wikimedia.org/r/152186

gerritbot added a comment.Aug 6 2014, 10:50 PM

Change 152186 abandoned by Bartosz Dziewoński:
Parse HTML in JavaScript failure notices

Reason:
Bah…

https://gerrit.wikimedia.org/r/152186

gerritbot added a comment.Aug 6 2014, 10:51 PM

Change 147320 had a related patch set uploaded by Bartosz Dziewoński:
Do not show raw HTML code in notification

https://gerrit.wikimedia.org/r/147320

gerritbot added a comment.Aug 6 2014, 10:58 PM

Change 147320 merged by jenkins-bot:
Do not show raw HTML code in notification

https://gerrit.wikimedia.org/r/147320

matmarex added a comment.Aug 6 2014, 10:59 PM

Turns out this had a patch by Fomafix pending for almost three weeks.

Aklapper added a project: Voice & Tone.May 24 2021, 9:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL