Page MenuHomePhabricator

AJAX review errors show HTML markup in notification
Closed, ResolvedPublic

Description

screenshot of the problem

The AJAX implementation of flagged revs, returns html fragments in case of errors: <p><b>Unable to review this revision</b></p><p>Permission denied</p>.

This textual html fragment is passed straight to mw.notify, but mw.notify can only handle: HTML dom, jQueryElements, a message key or plain text.


Version: master
Severity: normal

Attached:

Details

Reference
bz67023

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:35 AM
bzimport set Reference to bz67023.
  • Bug 67484 has been marked as a duplicate of this bug. ***

Affected message key for better search result: 'revreview-failed'

Change 152186 had a related patch set uploaded by Bartosz Dziewoński:
Parse HTML in JavaScript failure notices

https://gerrit.wikimedia.org/r/152186

Change 152186 abandoned by Bartosz Dziewoński:
Parse HTML in JavaScript failure notices

Reason:
Bah…

https://gerrit.wikimedia.org/r/152186

Change 147320 had a related patch set uploaded by Bartosz Dziewoński:
Do not show raw HTML code in notification

https://gerrit.wikimedia.org/r/147320

Change 147320 merged by jenkins-bot:
Do not show raw HTML code in notification

https://gerrit.wikimedia.org/r/147320

Turns out this had a patch by Fomafix pending for almost three weeks.