Page MenuHomePhabricator

$wgUsersNotifiedOnAllChanges sends mail even if already sent via watchlist
Open, NormalPublic

Description

Prevent duplicate emails from being sent

If you have a page in your watchlist, and you are in the wgUsersNotifiedOnAllChanges array, you receive two emails about the changed page.


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz67041

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:36 AM
bzimport added a project: MediaWiki-Watchlist.
bzimport set Reference to bz67041.
Turnstep created this task.Jun 24 2014, 6:06 PM

Of course, should use getName() or similar as the keys, not the User object.

Hi Greg! Thanks for the patch!
You are very welcome to use Wikimedia Developer access

https://www.mediawiki.org/wiki/Developer_access

to submit the patch as a Git branch directly into Gerrit:

https://www.mediawiki.org/wiki/Git/Tutorial

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use https://tools.wmflabs.org/gerrit-patch-uploader/

Change 143373 had a related patch set uploaded by Rohan013:
Checks for each user in the $wgUsersNotifiedOnAllChange list before sending the mail

https://gerrit.wikimedia.org/r/143373

saper added a subscriber: saper.May 13 2015, 8:10 PM

Change 143373 had a related patch set uploaded (by Legoktm):
$wgUsersNotifiedOnAllChanges should not send mail twice

https://gerrit.wikimedia.org/r/143373

Change 143373 merged by jenkins-bot:
$wgUsersNotifiedOnAllChanges should not send mail twice

https://gerrit.wikimedia.org/r/143373