Page MenuHomePhabricator
Create Task
Maniphest T69060

Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )"
Closed, DeclinedPublic
Actions

Description

  1. GadgetsTest::testPreferences

Failed asserting that false is true.

/srv/mediawiki/extensions/Gadgets/tests/GadgetTest.php:75
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/mediawiki/tests/phpunit/phpunit.php:160

The assert that is failing is:

$this->assertTrue( isset( $options['<gadget-section-keep-section2>'] ) );

Version: master
Severity: normal

Details

Reference
bz67060

Related Objects
Search...

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:37 AM
bzimport added a project: MediaWiki-extensions-Gadgets.
bzimport set Reference to bz67060.
bzimport added a subscriber: Unknown Object (MLST).
ori created this task.Jun 24 2014, 11:47 PM
hashar added a comment.Jun 30 2014, 2:08 PM

We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.

Legoktm added a comment.Jul 2 2014, 10:57 AM

Just ran the tests and they passed for me...

Legoktm added a comment.Jul 2 2014, 11:02 AM

I checked out the parent of I9b7fb065ea9e235e6c5e7ea5116ccacac91f8846 and they still passed. Is it still failing for you Ori?

MaxSem added a comment.Jul 3 2014, 6:54 AM

Not reproduceable anymore.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL