Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )"
Closed, DeclinedPublic
Actions

Description

GadgetsTest::testPreferences

Failed asserting that false is true.

/srv/mediawiki/extensions/Gadgets/tests/GadgetTest.php:75
/srv/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/mediawiki/tests/phpunit/phpunit.php:160

The assert that is failing is:

$this->assertTrue( isset( $options['&lt;gadget-section-keep-section2&gt;'] ) );

Version: master
Severity: normal

Details

Reference: bz67060

Related Objects
Search...

Status	Assigned	Task
Resolved	• hashar	T60772 common gating job for mediawiki core and extensions
Open	None	T69216 Have unit tests of all wmf deployed extensions pass when installed together, in both PHP-Zend and HHVM (tracking)
Declined	None	T69060 Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )"

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:37 AM

bzimport added a project: Gadgets.

bzimport set Reference to bz67060.

bzimport added a subscriber: Unknown Object (MLST).

ori created this task.Jun 24 2014, 11:47 PM

We really need tests to pass when all wmf extensions are installed together. That is preventing us from progression toward the HHVM migrating. Raising priority to High.

Just ran the tests and they passed for me...

I checked out the parent of I9b7fb065ea9e235e6c5e7ea5116ccacac91f8846 and they still passed. Is it still failing for you Ori?

Not reproduceable anymore.

Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['&lt;gadget-section-keep-section2&gt;'] )"Closed, DeclinedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Gadgets: Fix failing unit test "GadgetsTest::testPreferences: isset( $options['<gadget-section-keep-section2>'] )"
Closed, DeclinedPublic
Actions

Related Objects
Search...