Page MenuHomePhabricator

In desktop mode of Minerva, section toggling is broken. It should probably be removed.
Closed, ResolvedPublic

Description

See:
https://en.wikipedia.org/w/index.php?title=Textile_manufacturing&useskin=minerva

Since all sections are open by default in Minerva's desktop mode, clicking the open section toggler doesn't do anything (nor does closing a section). We should probably just not load the section toggling code in desktop mode.


Version: unspecified
Severity: normal

Details

Reference
bz67105

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:40 AM
bzimport set Reference to bz67105.
bzimport added a subscriber: Unknown Object (MLST).
kaldari created this task.Jun 25 2014, 10:18 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/Kg8RdCmT

This is actually due to the fact that we don't have sections in the desktop DOM (since we don't apply MobileFormatter). Since we don't really need section toggling on desktop, Max agrees it makes more sense to just remove the toggling feature in desktop rather than introducing sections.

Change 143062 had a related patch set uploaded by Florianschmidtwelzow:
Minerva Desktop: Remove toggling and fix TOC

https://gerrit.wikimedia.org/r/143062

Set to new again, after split PS in two commits (see comment from kaldari) :)

Change 143191 had a related patch set uploaded by Florianschmidtwelzow:
Minerva Desktop: Remove toggling sections

https://gerrit.wikimedia.org/r/143191

Change 143191 merged by jenkins-bot:
Minerva Desktop: Remove toggling sections

https://gerrit.wikimedia.org/r/143191

both merged, set as resolved :)