Page MenuHomePhabricator
Create Task
Maniphest T69107

Merge Mantle event emitter and OO.EventEmitter
Closed, ResolvedPublic
Actions

Description

Right now, Mantle's event emitter is just a wrapper around jQuery, and its API is an exact subset of OO.EventEmitter's API (apart from the naming of .one() vs .once()). I wrote some ugly code that replaces Mantle's EventEmitter with OO's, and the tests still run.

It would be nice if we could have Mantle use OO.EventEmitter, but this isn't entirely trivial to rig up because OOjs's and Mantle's OO models are different.

Version: unspecified
Severity: normal

Details

Reference
bz67107

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:40 AM
• bzimport added a project: MediaWiki-extensions-Mantle.
• bzimport set Reference to bz67107.
• bzimport added a subscriber: Unknown Object (MLST).
Catrope created this task.Jun 26 2014, 12:35 AM
gerritbot added a comment.Sep 10 2014, 8:30 PM

Change 129336 had a related patch set uploaded by Jdlrobson:
Use Mantle version of Class, eventemitter and View

https://gerrit.wikimedia.org/r/129336

gerritbot added a comment.Sep 19 2014, 6:39 PM

Change 129336 merged by jenkins-bot:
Use Mantle version of Class, eventemitter and View

https://gerrit.wikimedia.org/r/129336

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL