Page MenuHomePhabricator

Flow front-end: moderation dialog issues
Closed, ResolvedPublic

Description

  1. Login to a wiki running new front end.
  2. Click post's action menu, choose Hide.

a) The title used to be "Hide post?" (flow-moderation-title-hide-post), now it mistakenly reuses the button "Hide" text (flow-post-action-hide-post).
b) The introductory text "Please explain why you're hiding this post." (flow-moderation-intro-hide-post) isn't shown.
c) There's no placeholder text "Enter your reason here" (flow-moderation-reason-placeholder) in the textarea.
d) After submitting the form you used to get a transient mw.notify() "toaster" display "The post was successfully hidden.\n{{GENDER:$2|Consider}} giving $1 feedback on this post." (flow-moderation-confirmation-hide-post)

In a quick chat May Galloway suggested:

  • Fix a)
  • Drop the introductory text b), and turn it into placeholder text c) specific to each moderation action (e.g. flow-moderation-placeholder-hide-post).
  • Probably revive d), see https://trello.com/c/lSIqjAdI but note bug 62612.

Version: master
Severity: normal

Details

Reference
bz67226

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:31 AM
bzimport set Reference to bz67226.
bzimport added a subscriber: Unknown Object (MLST).

Card for fixing wrong "Hide post?" message: https://trello.com/c/LFNpW1BX

Card for redesigning the moderation dialog: https://trello.com/c/OLnPx7M4

Change 146653 had a related patch set uploaded by EBernhardson:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/146653

Change 146653 merged by jenkins-bot:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/146653

Change 148451 had a related patch set uploaded by EBernhardson:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/148451

Change 148451 merged by jenkins-bot:
Wrong messages used in moderation dialogs

https://gerrit.wikimedia.org/r/148451

The messages were improved.

Still no d) "toaster" display after moderating "The post was successfully hidden.\n{{GENDER:$2|Consider}} giving $1 feedback on this post."

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM