Page MenuHomePhabricator

VisualEditor: Prompt for edit summary preference breaks the save dialog
Closed, ResolvedPublic

Description

If a user has the preference "Prompt me when entering a blank edit summary" selected, VisualEditor's save dialog has to be closed and reopened to work. The "Save" button is greyed out even when an edit summary is entered.

To reproduce:

  1. Enable Preferences>Editing>tick Prompt me when entering a blank edit summary
  2. Attempt to save a VE edit and the prompt for an edit summary comes up, with save not an option
  3. Enter an edit summary
  4. Save is still not an option
  5. Exit out of the dialog by clicking X and click save again
  6. You can now save your edit with an edit summary

Firefox 30 on Mac OS X Mavericks.


Version: unspecified
Severity: normal

Details

Reference
bz67345

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz67345.
Keegan created this task.Jul 1 2014, 3:39 AM

Sounds like we need to code in that the you-must-set-an-edit-summary message is a recoverable error.

Change 143326 had a related patch set uploaded by Alex Monk:
After showing missing edit summary error, mark the dialog as not pending anymore

https://gerrit.wikimedia.org/r/143326

This was probably an oversight on my part in Gerrit change 135945

Change 143326 merged by jenkins-bot:
After showing missing edit summary error, mark the dialog as not pending anymore

https://gerrit.wikimedia.org/r/143326