Converting a MWNumberedExternalLinkNode to MWExternalLinkAnnotation from the UI (link inspector) loses annotations on the node, even though there is code in place that aims handle this.
See the behavior of the 'convert' variable in ve.ui.MWLinkNodeInspector.prototype.getTeardownProcess.
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | matmarex | T53309 VisualEditor: Support creation of auto-numbered external links and to convert them to labeled ones | |||
| Resolved | matmarex | T69377 VisualEditor: Converting a numbered external link to a regular one from the link inspector drops the annotations |
This is because the node is removed from DM before its annotations are copied. Let me just fix it while I'm at it. :)
Change 143387 had a related patch set uploaded by Bartosz Dziewoński:
MWLinkNodeInspector: Actually preserve annotations when converting to link annotation
Change 143387 merged by jenkins-bot:
MWLinkNodeInspector: Actually preserve annotations when converting to link annotation