Page MenuHomePhabricator

Flow: in history, the post revision links have codecruft in the TopicTitle, and topic creation is an error
Closed, ResolvedPublic

Description

screenshot

At http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&workflow=rvnsbapurhs9pdog&action=history
and http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&action=history

The comment timestamps (post revision) lead to a diff that has codecruft in the title.
(See screenshot. Here's an example paste of the text, from the topic named "test":

<p data-parsoid='{"dsr":[0,31,0,0]}'>test <a rel="mw:ExtLink" href="http://ee-flow.wmflabs.org" data-parsoid='{"stx":"url","dsr":[5,31,0,0]}'>http://ee-flow.wmflabs.org</a></p>


The last timestamp (topic revision (aka original topic creation)) leads to an error message:

"
Invalid value was provided for loading flow content.

Return to Main Page.

[d32a0cbc] /w/index.php?title=Talk:Sandbox&workflow=rvnsbapurhs9pdog&topic_revId=rvnsbapwbm7x1ke8 Exception from line 162 of /srv/mediawiki/extensions/Flow/includes/Model/UUID.php: Unknown input to UUID class

Backtrace:

#0 /srv/mediawiki/extensions/Flow/includes/Block/Topic.php(581): Flow\Model\UUID::create(string)
#1 /srv/mediawiki/extensions/Flow/includes/Block/Topic.php(470): Flow\Block\TopicBlock->renderPostAPI(Flow\Templating, array)
#2 /srv/mediawiki/extensions/Flow/includes/View.php(103): Flow\Block\TopicBlock->renderAPI(Flow\Templating, array)
#3 /srv/mediawiki/extensions/Flow/includes/Actions/Action.php(74): Flow\View->show(Flow\WorkflowLoader, string)
#4 /srv/mediawiki/extensions/Flow/includes/Actions/Action.php(28): Flow\Actions\FlowAction->showForAction(string)
#5 /srv/mediawiki/includes/Wiki.php(431): Flow\Actions\FlowAction->show()
#6 /srv/mediawiki/includes/Wiki.php(295): MediaWiki->performAction(Article, Title)
#7 /srv/mediawiki/includes/Wiki.php(603): MediaWiki->performRequest()
#8 /srv/mediawiki/includes/Wiki.php(452): MediaWiki->main()
#9 /srv/mediawiki/index.php(46): MediaWiki->run()
#10 {main}
"


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz67378

Event Timeline

bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz67378.
bzimport added a subscriber: Unknown Object (MLST).
Quiddity created this task.Jul 1 2014, 5:59 PM

Change 143530 had a related patch set uploaded by Bsitu:
Add topic & post single revision view

https://gerrit.wikimedia.org/r/143530

Change 143530 merged by jenkins-bot:
Add topic & post single revision view

https://gerrit.wikimedia.org/r/143530

All patches mentioned in this report are either merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

(In reply to Danny Horn from comment #1)

Added to Trello card: https://trello.com/c/dUhmpMXq

"Card not found.
This card may be on a private board. You may be able to view it by logging in."

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM